Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(frontend): Consistent buttons and their styles throughout the app #6835

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

amanape
Copy link
Member

@amanape amanape commented Feb 19, 2025

image

Screenshot 2025-02-20 at 9 17 29 PM
Screenshot 2025-02-20 at 9 17 35 PM

Brand buttons now support a custom startContent that accepts react nodes


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:ede4c55-nikolaik   --name openhands-app-ede4c55   docker.all-hands.dev/all-hands-ai/openhands:ede4c55

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

@amanape I still see a lot of inconsistency in the blue and gray backgrounds

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

I think mainly on the settings page
Screenshot 2025-02-20 at 10 00 07 AM

Screenshot 2025-02-20 at 10 01 04 AM

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

@amanape let's standardize on the blue, I think it looks better with the yellow

@amanape
Copy link
Member Author

amanape commented Feb 20, 2025

This PR is actually more buttons-only; bg color consistency is handled in #6833

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

I think we lost the vscode logo
Uploading Screenshot 2025-02-20 at 10.02.51 AM.png…

@amanape amanape changed the title hotfix(frontend): Consistent buttons and colors throughout the app hotfix(frontend): Consistent buttons and their styles throughout the app Feb 20, 2025
@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

@amanape let's do both in the same PR, otherwise it feels inconsistent

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

VS code logo shot
Screenshot 2025-02-20 at 10 02 51 AM

@amanape
Copy link
Member Author

amanape commented Feb 20, 2025

@rbren I've removed the VSCode logo and the GitHub logo - should I keep both?

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

Why not keep them?

@rbren
Copy link
Collaborator

rbren commented Feb 20, 2025

Yeah I think they look better with the logos there

@amanape
Copy link
Member Author

amanape commented Feb 20, 2025

Why not keep them?

Consistency reasons - didn't think much of it. Will add them back 👍

@amanape amanape requested a review from rbren February 20, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants