fix: handle escaped quotes in PS1 metadata parsing

openhands/events/observation/commands.py

@@ -34,20 +34,19 @@ class CmdOutputMetadata(BaseModel):
     def to_ps1_prompt(cls) -> str:
         """Convert the required metadata into a PS1 prompt."""
         prompt = CMD_OUTPUT_PS1_BEGIN
+        # Create the JSON string with proper escaping
         json_str = json.dumps(
             {
                 'pid': '$!',
                 'exit_code': '$?',
-                'username': r'\u',
-                'hostname': r'\h',
-                'working_dir': r'$(pwd)',
-                'py_interpreter_path': r'$(which python 2>/dev/null || echo "")',
+                'username': r'\u',  # Raw string to avoid double escaping
+                'hostname': r'\h',  # Raw string to avoid double escaping
+                'working_dir': '$(pwd)',
+                'py_interpreter_path': '$(which python 2>/dev/null || echo "")',
             },
             indent=2,
         )
-        # Make sure we escape double quotes in the JSON string
-        # So that PS1 will keep them as part of the output
-        prompt += json_str.replace('"', r'\"')
+        prompt += json_str
         prompt += CMD_OUTPUT_PS1_END + '\n'  # Ensure there's a newline at the end
         return prompt
 
@@ -56,7 +55,8 @@ def matches_ps1_metadata(cls, string: str) -> list[re.Match[str]]:
         matches = []
         for match in CMD_OUTPUT_METADATA_PS1_REGEX.finditer(string):
             try:
-                json.loads(match.group(1).strip())  # Try to parse as JSON
+                # Parse the JSON as is
+                json.loads(match.group(1).strip())
                 matches.append(match)
             except json.JSONDecodeError:
                 logger.warning(
@@ -69,7 +69,8 @@ def matches_ps1_metadata(cls, string: str) -> list[re.Match[str]]:
     @classmethod
     def from_ps1_match(cls, match: re.Match[str]) -> Self:
         """Extract the required metadata from a PS1 prompt."""
-        metadata = json.loads(match.group(1))
+        # Parse the JSON as is
+        metadata = json.loads(match.group(1).strip())
         # Create a copy of metadata to avoid modifying the original
         processed = metadata.copy()
         # Convert numeric fields