Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type checking errors in resolver directory #6738

Merged
merged 5 commits into from
Feb 19, 2025
Merged

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Feb 14, 2025

This PR fixes type checking errors in the openhands/resolver directory by:

  1. Adding type hints to the parse_git_binary_diff function in openhands/resolver/patching/patch.py
  2. Fixing the type checking error by properly handling the case where the input is a string vs a list of strings

The changes ensure that all mypy type checking errors in the resolver directory are resolved.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:c00aa10-nikolaik   --name openhands-app-c00aa10   docker.all-hands.dev/all-hands-ai/openhands:c00aa10

@neubig neubig changed the base branch from feature/strict-mypy-checks to main February 17, 2025 21:00
@neubig neubig force-pushed the fix/resolver-mypy-errors branch from 01868f1 to 305a4a8 Compare February 18, 2025 21:29
@neubig neubig marked this pull request as ready for review February 18, 2025 22:36
@neubig neubig requested a review from malhotra5 February 18, 2025 22:36
Copy link
Contributor

@malhotra5 malhotra5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@neubig neubig merged commit f4e5fb2 into main Feb 19, 2025
14 checks passed
@neubig neubig deleted the fix/resolver-mypy-errors branch February 19, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants