-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify fn calling usage #6596
Conversation
f'Function calling not enabled for model {self.llm.config.model}. ' | ||
'Mocking function calling via prompting.' | ||
) | ||
self.mock_function_calling = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really used in the agent, it's used in llm.py
Hi! I started running the integration tests on your PR. You will receive a comment with the results shortly. |
Trigger by: Pull Request (integration-test label on PR #6596) Total cost: USD 0.08
Integration Tests Report (DeepSeek) Total cost: USD 0.02
Integration Tests Report Delegator (Haiku) Total cost: USD 0.05
Integration Tests Report Delegator (DeepSeek) Total cost: USD 0.00
Integration Tests Report VisualBrowsing (DeepSeek) Total cost: USD 0.00
Download testing outputs (includes both Haiku and DeepSeek results): Download |
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR proposes to clean up
mock_function_calling
var from the agent. The llm knows if it supports it.It's just a little clean-up, to help us read this code (part of refactoring towards message <-> event)
To run this PR locally, use the following command: