Fix file descriptor leak in S3FileStore #6486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential file descriptor leak in the S3FileStore implementation. The issue was in the
read()
method where the StreamingBody object from boto3 was not being properly closed after use.Changes
read()
method to use a context manager (with
statement) to ensure proper cleanup of the StreamingBody objectWhy
The fix ensures that the stream is properly closed even if an error occurs during reading, preventing file descriptor leaks.
To run this PR locally, use the following command: