feat(resolver): implement gitlab resolver #6458
Conversation
Signed-off-by: José Luis Di Biase <[email protected]>
…pull-urls-function refactor(resolver) add pull url and authorize url functions
branch_exists and get_branch_name functions refactored
* get_branch_url * implemente get_branch_url() in branch_exists() * get_branch_url --------- Co-authored-by: Charlie <[email protected]>
wtiger9218
changed the title
wtiger9218
force-pushed
the
resolver_gitlab_openhands
branch
from
24cd9a5 to
ce78f3e
Compare
|
Hey @wtiger9218 and @symbaventures, thanks a bunch for putting this together I'm getting started on reviewing this, but the PR is quite large! It will take me some time reading through the changes and adequately testing things. That being said, it would be much preferred if you could break up this PR into multiple smaller ones. For example,
|
Hi @malhotra5, Thank you for your reply. |
There was a problem hiding this comment.
Overall this seems reasonable to me, and a good first start at a GitLab integration.
Can we add docs as a sibling to https://docs.all-hands.dev/modules/usage/how-to/github-action?
Are the API routes used at all currently?
Going forward I'd like to see the frontend accept a gitlab token, and then have generic APIs for GET /repositories etc which collate results from both APIs. But that doesn't need to be this PR
I'm going to defer to @malhotra5 and others on final approval here
@rbren Thank you for your review. I just updated the above suggestion. Currently, the API routes aren't used. |
|
I'm gonna take a pause from reviewing this for tonight - I'll come back to this tomorrow. I've mostly confirmed everything works so far, so we're almost at the finish line! |
|
Could you also add a file similar to this https://github.com/All-Hands-AI/OpenHands/blob/main/docs/modules/usage/how-to/github-action.md? Please include information that is needed to setup Openhands for Gitlab + any other custom variables as well |
|
My concerns were addressed, thank you! I'll defer to @malhotra5 for final approval and merge. |
There was a problem hiding this comment.
LGTM! Thanks a lot for your patience during the review process and hard work!
I'll be running GitHub actions to make sure tests are passing before we can merge these changes. Please be on the lookout for failed actions and see if you can update the code until its passing
|
@malhotra5 All tests have passed. ❤ |
|
Let's merge this 🥳 |
This change introduces support for GitLab in the Resolver by:
The implementation includes updates to the Resolver logic to identify and process GitLab repositories and authenticate using personal access tokens where required.
End-user friendly description of the problem this fixes or functionality that this introduces
This PR introduces GitLab support in the Resolver, allowing OpenHands users to integrate with GitLab-hosted repositories for seamless resolution and processing.
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR enhances the Resolver by adding GitLab support, enabling users to resolve repositories hosted on GitLab in addition to GitHub. This required adding logic to handle GitLab-specific URL structures and authentication mechanisms while maintaining compatibility with existing GitHub functionality.