Feat - browser client can now close sessions. #6088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Client can now instruct server to delete a running session. Added framework for commanding that a session stops. **
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR fixes an issue where conversations could not be deleted while they were running. The changes include:
delete_conversation
to properly close the session when attempting to delete a running conversation instead of returning Falseclose_session
method to SessionManager to handle session closing across the clusterclose_session
message type in the session managerTesting
To test:
To run this PR locally, use the following command: