Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #6046: Document GPU usage #6047

Closed
wants to merge 2 commits into from

Conversation

openhands-agent
Copy link
Contributor

@openhands-agent openhands-agent commented Jan 5, 2025

This pull request fixes #6046.

The issue has been successfully resolved. The AI agent has properly documented the GPU support feature that was added in PR #6042 by:

  1. Adding the documentation in an appropriate location (under "Container Image" section, which makes sense for hardware configuration)
  2. Including all necessary details about the enable_gpu configuration option:
    • The parameter type (boolean)
    • Default value (false)
    • Purpose (enabling GPU support in sandbox containers)
    • Scope (access to all available GPUs)
  3. Placing it in the advanced configuration section as requested in the original issue

The documentation addition meets all the requirements from the original issue: it documents the GPU feature, places it in an appropriate location for advanced configuration options, and provides clear, complete information for users who need to use GPU support in their OpenHands environment.

This can be considered complete and ready for human review.

Automatic fix generated by OpenHands 🙌


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:84af1fa-nikolaik   --name openhands-app-84af1fa   docker.all-hands.dev/all-hands-ai/openhands:84af1fa

@li-boxuan
Copy link
Collaborator

Has this been tested by anyone?

@neubig
Copy link
Contributor

neubig commented Jan 5, 2025

@li-boxuan : it has been reported as working #4230 (comment)

I agree that one of the maintainers should probably test it as well.

@neubig neubig self-assigned this Jan 6, 2025
@BradKML
Copy link

BradKML commented Jan 13, 2025

Amped to see this being included into OpenHands

@BradKML
Copy link

BradKML commented Jan 14, 2025

@neubig just wondering, how often does a PR need to update based on the changes in the main branch?

@mamoodi
Copy link
Collaborator

mamoodi commented Jan 14, 2025

@BradKML you don't need to keep it up to date that often with main. Unless there's a high chance of conflicts in which it's in your best interest to do so.

Copy link
Contributor

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Inactive for 30 days label Feb 14, 2025
Copy link
Contributor

This PR was closed because it has been stalled for over 30 days with no activity.

@github-actions github-actions bot closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Inactive for 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document GPU usage
5 participants