Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the event stream fix after it's no longer a dataclass #5948

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented Dec 31, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    Fix loading the stream from the file store.

We just removed the @ dataclass annotation from EventStream. There is actually another detail about dataclass: it was calling __post_init__ implicitly. Without it, it will never be called and the stream is not restored.

This PR fixes it.


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:ab5d4c9-nikolaik   --name openhands-app-ab5d4c9   docker.all-hands.dev/all-hands-ai/openhands:ab5d4c9

@enyst enyst requested review from rbren and xingyaoww December 31, 2024 21:36
@enyst enyst changed the title Load the event stream fix Load the event stream fix after it's no longer a dataclass Dec 31, 2024
Copy link
Collaborator

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops how bad was this break?

@enyst enyst enabled auto-merge (squash) December 31, 2024 21:53
@enyst
Copy link
Collaborator Author

enyst commented Dec 31, 2024

oops how bad was this break?

Well, for a New Year's Eve, pretty tame! ❤️

@enyst enyst merged commit 2ec2f25 into main Dec 31, 2024
13 of 14 checks passed
@enyst enyst deleted the enyst/post-init branch December 31, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants