Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove logout on settings upgrade #5945

Merged
merged 2 commits into from
Dec 31, 2024
Merged

remove logout on settings upgrade #5945

merged 2 commits into from
Dec 31, 2024

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Dec 31, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    no changelog

Give a summary of what the PR does, explaining any non-trivial design decisions

This was logging out new users immediately after they log in. Goal was to transition them over to the app-based auth instead of oauth--not sure the implications here, but users may have to manually log out and back in


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:05c2313-nikolaik   --name openhands-app-05c2313   docker.all-hands.dev/all-hands-ai/openhands:05c2313

@rbren rbren marked this pull request as ready for review December 31, 2024 18:11
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@rbren rbren enabled auto-merge (squash) December 31, 2024 18:13
@rbren rbren merged commit 7ae1f76 into main Dec 31, 2024
16 checks passed
@rbren rbren deleted the rb/fix-logout branch December 31, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants