Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for when settings are unset #5921

Closed
wants to merge 6 commits into from
Closed

Fix for when settings are unset #5921

wants to merge 6 commits into from

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Dec 30, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    no changelog

Give a summary of what the PR does, explaining any non-trivial design decisions

Currently if the settings endpoint returns a 404, the user doesn't properly get prompted to fill out their settings


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:e0e5792-nikolaik   --name openhands-app-e0e5792   docker.all-hands.dev/all-hands-ai/openhands:e0e5792

@rbren rbren marked this pull request as ready for review December 30, 2024 16:33
@amanape
Copy link
Member

amanape commented Dec 30, 2024

Blocked by #5873 since it makes some changes to when/where settings are saved

Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants