Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better state restore logic #5838

Closed
wants to merge 2 commits into from
Closed

better state restore logic #5838

wants to merge 2 commits into from

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Dec 26, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    no changelog

Give a summary of what the PR does, explaining any non-trivial design decisions

We're occasionally seeing problems with session restoration. This should help debug


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:dd80f1a-nikolaik   --name openhands-app-dd80f1a   docker.all-hands.dev/all-hands-ai/openhands:dd80f1a

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it will stop worrying people!

@rbren
Copy link
Collaborator Author

rbren commented Dec 26, 2024

Not currently working properly :/

@rbren
Copy link
Collaborator Author

rbren commented Dec 26, 2024

Abandoning this. The directory gets created too aggressively to really rely on that as a signal of restoring a session. There's probably a better way

@rbren rbren closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants