Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: add RuntimeManager class #5788

Closed
wants to merge 33 commits into from
Closed

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Dec 24, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    no changelog

Give a summary of what the PR does, explaining any non-trivial design decisions

This should be a pretty clean no-op. But I really want to expand this so that there are separate implementations for each runtime class. Right now the runtime classes themselves are doing a lot of extra lifting for managing runtimes in an external environment (docker, runtime-api, 3p providers)


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:c377f9e-nikolaik   --name openhands-app-c377f9e   docker.all-hands.dev/all-hands-ai/openhands:c377f9e

@rbren rbren marked this pull request as ready for review December 24, 2024 17:00
@rbren rbren force-pushed the feature/runtime-manager branch from acb08bc to 30f6166 Compare December 24, 2024 19:19
@rbren rbren marked this pull request as draft December 24, 2024 20:03
@rbren rbren marked this pull request as ready for review December 26, 2024 13:54
@mamoodi
Copy link
Collaborator

mamoodi commented Jan 14, 2025

@rbren I'm guessing you'll be working on this when you have time?

@rbren
Copy link
Collaborator Author

rbren commented Jan 14, 2025

Yeah I might need to just recreate given the merge conflicts. But it was hypothetically ready for review 😄

@enyst
Copy link
Collaborator

enyst commented Jan 14, 2025

Yeah, the review process is in trouble. What may help, at the time of submission, is to use request review directly when submitted. We should probably notify people to try to always do that.

@enyst enyst requested a review from xingyaoww January 14, 2025 21:51
@rbren rbren closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants