[Regression]: Fix modal orders

[malhotra5]

End-user friendly description of the problem this fixes or functionality that this introduces

• Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

---

Give a summary of what the PR does, explaining any non-trivial design decisions

The SettingsModal was being displayed first thing even when user isn't authed or on the access list. This PR fixes this bug (request both github auth and access list permission to see the modal). This results in the following flow -

1. Show waitlist modal first thing if user is not allowed (requires github auth to find out if user is on waitlist)
2. If settings are out of date, the SettingsModal is displayed by frontend/src/components/features/sidebar/sidebar.tsx (only if user is allowed on access list)

---

Link of any specific issues this addresses

---

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:49e3096-nikolaik   --name openhands-app-49e3096   docker.all-hands.dev/all-hands-ai/openhands:49e3096

[rbren]

Does it still render the modal if settings are out of date?

[malhotra5]

Yes, it is handled inside sidebar.tsx

The logic here was duplicate