Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolver]: Add target branch param #5642

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Conversation

malhotra5
Copy link
Contributor

@malhotra5 malhotra5 commented Dec 17, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR adds the target branch options to the workflow definitions


Link of any specific issues this addresses
#5205


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:c105b13-nikolaik   --name openhands-app-c105b13   docker.all-hands.dev/all-hands-ai/openhands:c105b13

@malhotra5 malhotra5 requested a review from neubig December 17, 2024 03:11
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@malhotra5 malhotra5 enabled auto-merge (squash) December 21, 2024 00:09
@malhotra5 malhotra5 merged commit 5ea096e into main Dec 21, 2024
12 checks passed
@malhotra5 malhotra5 deleted the resolver/push-to-target-branch branch December 21, 2024 00:33
@enyst
Copy link
Collaborator

enyst commented Dec 22, 2024

@malhotra5 I think this PR may have caused a regression? https://github.com/All-Hands-AI/OpenHands/actions/runs/12449559613/job/34755341806#step:10:63

On further thought, this is weird, this PR is not in the release and I ran with the openhands-agent.

@malhotra5 malhotra5 restored the resolver/push-to-target-branch branch December 22, 2024 01:00
malhotra5 added a commit that referenced this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants