Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Disable terminal stdin if the runtime is starting up #5625

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

amanape
Copy link
Member

@amanape amanape commented Dec 16, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • User could submit commands before the runtime is active, causing a fatal error

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below


Give a summary of what the PR does, explaining any non-trivial design decisions

  • Disable stdin until the runtime is active
  • A small indicator on the terminal label that shows whether the terminal is enabled or disabled (based on runtime status)
    Screenshot 2024-12-16 at 12 39 13

Link of any specific issues this addresses
Resolves #5557


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:2126a8e-nikolaik   --name openhands-app-2126a8e   docker.all-hands.dev/all-hands-ai/openhands:2126a8e

@amanape amanape self-assigned this Dec 16, 2024
@amanape amanape marked this pull request as draft December 16, 2024 11:27
@amanape amanape marked this pull request as ready for review December 17, 2024 05:17
@amanape amanape requested a review from enyst December 17, 2024 05:17
@enyst enyst changed the title fix(frontend): Disable terminal stdin if the runtime is not active fix(frontend): Disable terminal stdin if the runtime is starting up Dec 17, 2024
Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amanape amanape merged commit b04ec03 into main Dec 17, 2024
17 checks passed
@amanape amanape deleted the ALL-827/disable-terminal-if-not-active branch December 17, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: App breaks when running a command before runtime is active
2 participants