Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Trigger VSCode URL query only when runtime is active #5622

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

amanape
Copy link
Member

@amanape amanape commented Dec 16, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • The query responsible for fetching the VSCode URL would run before the runtime is active, resulting in an error thrown in the terminal

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below


Give a summary of what the PR does, explaining any non-trivial design decisions

  • Only query when runtime is active

Link of any specific issues this addresses
Resolves #5606


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:b5d38cb-nikolaik   --name openhands-app-b5d38cb   docker.all-hands.dev/all-hands-ai/openhands:b5d38cb

@amanape amanape self-assigned this Dec 16, 2024
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@mamoodi mamoodi merged commit dabf0ce into main Dec 16, 2024
15 checks passed
@mamoodi mamoodi deleted the ALL-826/enable-vcscode-url-query branch December 16, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants