[Resolver][Bug]: Fix success list to str representation bug #5351
Conversation
| @@ -334,6 +334,23 @@ def reply_to_comment(github_token: str, comment_id: str, reply: str): | |||
| response.raise_for_status() | |||
|
|
|||
|
|
|||
| def send_comment_msg(base_url: str, issue_number: int, github_token: str, msg: str): | |||
There was a problem hiding this comment.
Just a nit: could we add a docstring?
There was a problem hiding this comment.
@openhands-agent can you add a docstring to this new function? Note how the other docstrings are in the file, and keep the same style!
In particular, add the args without types.
There was a problem hiding this comment.
@malhotra5 this is funny, it added a docstring to another function 😂 1e26cf0
There was a problem hiding this comment.
@openhands-agent good job, now add a docstring to the new send_comment_msg function. Similarly, look how other docstrings are in the file, and keep the same style!
There was a problem hiding this comment.
Thank you for this fix, I hated the issue. I did have openhands fix this for me in my playground repo, but I am not sure among many changes if it even did exactly this - don't think so - just fallback processing. 😅 🤷
I'm not that familiar with the resolver code, but this makes perfect sense and FWIW it looks good to me. I'd love it if @neubig could take a look though.
|
New OpenHands update |
|
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
|
New OpenHands update |
|
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
Co-authored-by: Engel Nyst <[email protected]>
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
Instead of using
json.dumpswe were utilizing"\n".join()to serialize success explanations. This caused downstream problems when attempting deserialize them usingjson.loads().Link of any specific issues this addresses
#5234
To run this PR locally, use the following command: