-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(frontend) Refactor and move components #5290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a LOT here--is there an easy way to break it down into smaller PRs?
I assume this is all just refactoring and no functional changes--if you're confident w/ it I'm happy to approve but it's a lot to review 😅
Yes it is a lot, I recommend you switch to the branch on your local IDE so the changes will become clear. What I've done:
There is no change in behaviour or logic, only reducing component size/complexity, removing duplicates (e.g., two different |
Sorry, I know it is a lot but the alternative would have been ~10-20 different PRs for breaking down and/or moving each component. Since there is no behaviour/logic changes, I thought I'd just submit it at once. It is more of a "look at the IDE file tree PR" rather than testing features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like this is mostly just copy/paste, so the diff isn't as scary as it looks. 🍰
The objective of this PR is to
Components are organized into folders based on their domain, feature, or shared functionality.
base-button
to TailwindCSS for common button stylesThis PR does not break down or merge some of the modal components as much as I initially planned. I hope to address this soon by implementing the Compound Component Pattern, which should provide a more convenient and flexible way to build them.
To run this PR locally, use the following command: