Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default value of keep_runtime_alive from True to False #5288

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Nov 26, 2024

Change the default value of keep_runtime_alive from True to False

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

This flag effectively stops any runtimes from being recycled by docker. Though some may want to do this, it is almost certainly not the preferred behavior for most use cases


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:eec904f-nikolaik   --name openhands-app-eec904f   docker.all-hands.dev/all-hands-ai/openhands:eec904f

@tofarr tofarr marked this pull request as ready for review November 27, 2024 15:11
@enyst enyst requested a review from rbren November 29, 2024 03:55
@tofarr tofarr merged commit 92b38dc into main Dec 2, 2024
12 checks passed
@tofarr tofarr deleted the feat-change-keep-runtime-alive-default branch December 2, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants