Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): App index route (mainly file explorer) #5287

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

amanape
Copy link
Member

@amanape amanape commented Nov 26, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Move file explorer component to _oh.app._index directory
  • Refactor buttons into their own components
  • Break down the file explorer into smaller components
  • Migrate regular fetch for VSCode url to a useQuery

Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:ac47604-nikolaik   --name openhands-app-ac47604   docker.all-hands.dev/all-hands-ai/openhands:ac47604

@amanape amanape self-assigned this Nov 26, 2024
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@amanape amanape merged commit 5d36612 into main Nov 27, 2024
14 checks passed
@amanape amanape deleted the ALL-780/refactor-app-index branch November 27, 2024 05:46
SmartManoj added a commit to SmartManoj/Kevin that referenced this pull request Dec 8, 2024
@diwu-sf
Copy link
Contributor

diwu-sf commented Dec 11, 2024

@amanape I think this introduced a regression that repeatedly opens the VSCode when workspace tab is opened, see repro in #5519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants