Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): Root layout route #5275

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

amanape
Copy link
Member

@amanape amanape commented Nov 26, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions
This PR refactors the root layout route (_oh.tsx) into smaller, more manageable components, each staying under 150 lines. The route has also been moved from _oh.tsx to _oh/route.tsx for better organization (refer to the Remix route folder convention for details). Since these components are specific to the layout route, they have been placed in the same directory as the route for cohesion.

Extras

  • Remove ancient and unused /src/session.ts (relevant if our app is SSR, which we do not currently support)

Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:60d382c-nikolaik   --name openhands-app-60d382c   docker.all-hands.dev/all-hands-ai/openhands:60d382c

@amanape amanape self-assigned this Nov 26, 2024
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 - breaking up these controls makes sense

@amanape amanape merged commit 8fad6e6 into main Nov 26, 2024
14 checks passed
@amanape amanape deleted the ALL-734/break-components branch November 26, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants