Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolver]: Removing redundant checks #5196

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

malhotra5
Copy link
Contributor

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

Recently noticed that removing the conditionals in openhands/resolver/examples/openhands-resolver.yml makes no functional difference. Github skips the workflow appropriately by checking the same set of conditionals in .github/workflows/openhands-resolver.yml directly.

I'm in favor of removing the conditionals in the example since its a duplicate copy and maintaining it has become burdensome.

Example tests


Link of any specific issues this addresses

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@neubig neubig enabled auto-merge (squash) November 22, 2024 14:03
@neubig neubig merged commit 135a62c into All-Hands-AI:main Nov 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants