Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 404 issue for /config #5114

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix 404 issue for /config #5114

merged 2 commits into from
Nov 18, 2024

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Nov 18, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

no changelog


Give a summary of what the PR does, explaining any non-trivial design decisions

We currently get a 404 when using local runtimes--this should fix that

I also changed the name of the API endpoint


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:17e7cd6-nikolaik   --name openhands-app-17e7cd6   docker.all-hands.dev/all-hands-ai/openhands:17e7cd6

@rbren rbren marked this pull request as ready for review November 18, 2024 21:59
@rbren rbren enabled auto-merge (squash) November 18, 2024 22:03
@rbren rbren merged commit 6b89386 into main Nov 18, 2024
14 checks passed
@rbren rbren deleted the rb/fix-404-runtime-id branch November 18, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants