Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to merge to a specific target branch instead of main #5109

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

ryx2
Copy link
Contributor

@ryx2 ryx2 commented Nov 18, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

I usually develop onto my 'feature' branch, but there is no option to merge into the feature branch instead of the default branch


Link of any specific issues this addresses

@neubig neubig self-requested a review November 18, 2024 20:29
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for the contribution! But it looks like tests are failing, so hopefully @openhands-agent can fix them.

@neubig neubig added fix-me Attempt to fix this issue with OpenHands and removed fix-me Attempt to fix this issue with OpenHands labels Nov 18, 2024
@ryx2
Copy link
Contributor Author

ryx2 commented Nov 19, 2024

@neubig fixed up the test to take in the feature branch change :)

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@neubig neubig merged commit 2c58038 into All-Hands-AI:main Nov 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants