Add API endpoints for resolver functionality #5058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add /api/resolver/resolve-issue endpoint to resolve GitHub issues - Add /api/resolver/send-pr endpoint to create PRs/branches - Add tests for new endpoints - Make resolver functions async for better API integration
Keep the original implementation to avoid modifying core functionality
neubig
commented
Nov 15, 2024
1 task
Co-authored-by: openhands <[email protected]>
neubig
commented
Nov 16, 2024
neubig
added
fix-me
neubig
added
fix-me-experimental
and removed
fix-me
|
New OpenHands update |
|
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
neubig
commented
Nov 16, 2024
|
New OpenHands update |
|
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
1. Delete send_pull_request endpoint in listen.py 2. Remove file writing dependency in resolve_issue endpoint 3. Rename process_single_issue to create_pull_request_from_resolver_output 4. Update all references and fix tests
|
I'm going to close because we've refactored "listen.py" and it'd be easier to start from scratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of trying to implement the github resolution functionality in
listen.py.The main change in this PR is that it creates an API endpoint
resolve_issue()inlisten.pyfor calling the github resolver.The input to this function is governed by the data model in
openhands/server/data_models/issue_models.py.One big question I have is that this endpoint could take 20 minutes to run, which isn't typically a good way to create an endpoint. Do you have a suggestion for the best practice in implementing this?
Any feedback is welcome (cc @rbren)!
NOTE: separately, running linting commands resulted in some unrelated fixing of linting issues...
To run this PR locally, use the following command: