Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zip downloads #5009

Merged
merged 3 commits into from
Nov 14, 2024
Merged

fix zip downloads #5009

merged 3 commits into from
Nov 14, 2024

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Nov 14, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    no changelog

Give a summary of what the PR does, explaining any non-trivial design decisions

I broke this with the FD leak fix. This might cause leaks now? we need to fix everywhere that these requests are made and close the response


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:76b755f-nikolaik   --name openhands-app-76b755f   docker.all-hands.dev/all-hands-ai/openhands:76b755f

@rbren rbren marked this pull request as ready for review November 14, 2024 21:18
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Interesting that the request was not getting closed automagically

@rbren rbren merged commit f3b3566 into main Nov 14, 2024
13 checks passed
@rbren rbren deleted the rb/fix-zip branch November 14, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants