Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemini prompt caching #5005

Closed
wants to merge 2 commits into from
Closed

Gemini prompt caching #5005

wants to merge 2 commits into from

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented Nov 14, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:b24dfd3-nikolaik   --name openhands-app-b24dfd3   docker.all-hands.dev/all-hands-ai/openhands:b24dfd3

@enyst enyst marked this pull request as draft November 14, 2024 20:12
@enyst enyst self-assigned this Nov 21, 2024
@mamoodi
Copy link
Collaborator

mamoodi commented Nov 25, 2024

Just another small nudge for @enyst to check if this PR is still happening.

@enyst
Copy link
Collaborator Author

enyst commented Nov 25, 2024

Certainly! Thanks for the nudge. Just for the record, there are at least three different issues with this in liteLLM. Currently prompt caching is not enabled in oh for Gemini, so things shouldn't break for people but I'll come back to this in a bit!

@mamoodi
Copy link
Collaborator

mamoodi commented Dec 23, 2024

Were the litellm issues resolved at all?

@enyst enyst closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants