Fix issue #4985: [Bug]: Cannot exit the session when on Jupyter or Browser tab in the UI #4986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #4985.
Based on the issue description and AI agent's solution, the problem has been successfully resolved. The original bug was that the OpenHands icon (exit button) wasn't working on the Jupyter or Browser tabs, only functioning on the main workspace tab.
The fix was simple but effective - instead of using a strict path equality check (
location.pathname === "/app"
), the code now useslocation.pathname.startsWith("/app")
. This change means the exit functionality will work on any path that begins with "/app", including:This modification ensures users can exit their session from any tab in the UI, which directly addresses the reported bug. The solution maintains consistent behavior across the application while using a more inclusive path-matching approach.
A good PR description for human review would be:
"Fixed exit button functionality on Jupyter and Browser tabs by modifying path check condition. The exit button now works consistently across all application tabs by matching any path that starts with '/app' instead of requiring an exact match. This ensures users can exit their session from any location in the application."
Automatic fix generated by OpenHands 🙌
To run this PR locally, use the following command: