Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Show a loading indicator when downloading a zip #4833

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Nov 7, 2024

Show a Loading indicator when downloading a zip

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Currently, downloading a zip is a silent operation. This shows a working indicator when a zip file is downloading
image

image

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:23087ab-nikolaik   --name openhands-app-23087ab   docker.all-hands.dev/all-hands-ai/openhands:23087ab

@tofarr tofarr marked this pull request as ready for review November 7, 2024 18:13
Comment on lines +70 to +71
() => setWorking(false),
() => setWorking(false),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it set twice?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For success and error

@neubig
Copy link
Contributor

neubig commented Nov 8, 2024

Thank you, I'm happy to have this improvement!
Just a note that this fixes #4615

@amanape amanape merged commit 38b92f4 into main Nov 8, 2024
8 checks passed
@amanape amanape deleted the ux-loading-indicator-on-download branch November 8, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants