-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #4830: [Bug]: Copy-paste into the "What do you want to build?" bar doesn't work #4832
Conversation
…d?" bar doesn't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a perfect fix to me, amazing. But @amanape could you double-check?
BTW: I ran locally before and after and confirmed that this did indeed fix the bug.
Oh I see. @xingyaoww's chat input PR did this but I changed the position of the The only thing that OpenHands missed by a tiny bit are the tests (though I'm more than glad of the fact that it has attempted to do so). We have a test files for the chat input: Instead, OpenHands created a new file. Some events it utilizes could be improved if it read the previous tests (such as using BTW, is OpenHands instructed to write tests? |
OpenHands started fixing the pr! You can monitor the progress here. |
New OpenHands update |
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
Revert these commits. I noticed that it started over in the trajectory, I didn't seem to find my feedback there. It worked off the original issue it seems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The tests should be added to the already-existing file: https://github.com/All-Hands-AI/OpenHands/blob/main/frontend/__tests__/components/chat/chat-input.test.tsx
- Some lint rules are failing in frontend/src/components/chat-input.tsx
OpenHands started fixing the pr! You can monitor the progress here. |
New OpenHands update |
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
9987ff4
to
9e53ff7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and I think that it reflects @amanape's comments as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, we may need to use fireEvent instead of userEvent for just the case of copy-pasting images.
OpenHands started fixing the pr! You can monitor the progress here. |
OpenHands started fixing the pr! You can monitor the progress here. |
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
New OpenHands update |
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
2971dd2
to
654ade8
Compare
…enHands into openhands-fix-issue-4830
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good now. I wasn't able to get tests working properly with userEvent, but if it's important to do so maybe we can do so in a follow-up PR.
This pull request fixes #4830.
The issue has been successfully resolved. The AI identified and fixed the core problem where text pasting wasn't working in the chat input bar. The solution involved:
Automatic fix generated by OpenHands 🙌
To run this PR locally, use the following command: