(feat): Prompt engineering to remind o1 to generate a patch

[AlexCuadron]

End-user friendly description of the problem this fixes or functionality that this introduces

• [] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

---

Give a summary of what the PR does, explaining any non-trivial design decisions

O1 is very forgetful, it usually stops coding as soon as it replicates the issue.
Modified the environment reminder so that o1 remembers to output only one action and to only press finish whenever it has generated a patch.

---

Link of any specific issues this addresses

[enyst]

It would be good if @xingyaoww can take a look at it.

Currently, I believe we don't have function calling with o1. That might change, and then function calling allows multiple actions. Maybe that's okay, we just may need to adjust the other part (the finish part) in the prompt for function calling.

[AlexCuadron]

It would be good if @xingyaoww can take a look at it.

Currently, I believe we don't have function calling with o1. That might change, and then function calling allows multiple actions. Maybe that's okay, we just may need to adjust the other part (the finish part) in the prompt for function calls.

FC is not available from the API side, the biggest issue here is forgetting to generate a patch. Most of the git diffs generated by o1-prev or o1-mini are just reproduce_issue.py

[AlexCuadron]

Fixed! PTAL @xingyaoww

[xingyaoww]

Hmm giving it a second thought, i'm actually wondering if we can do this inside run_infer.py -- Can we just add this as a suffix in the initial instruction?

The reason is that the environment reminder will likely go away as i got this #4711 working -- then everything will be organized as "function calling" code

[AlexCuadron]

Fixed! PTAL, @xingyaoww

[xingyaoww]

A few nit - but overall LGTM!

[AlexCuadron]

Fixed! PTAL again :D @xingyaoww

[xingyaoww]

LGTM! Thanks!

[xingyaoww]

@AlexCuadron After giving it more thought - i think maybe we should revert or revise this -- basically the agent SHOULD NOT be aware of the patch directly, instead, they should simply interact with the environment to edit files & let us know when it finished - and we will grab a patch from git diff.

<IMPORTANT>
- You MUST generate only one action per turn!
- A patch is a set of changes to the source code of the codebase that you are given
- You MUST generate a patch that attempts to fix the issue described in the <pr_description>
</IMPORTANT>

[xingyaoww]

Can you share more info on how O1's behavior will be when this is not provided? I'd assume we maybe able to tweak other parts of the instruction to get it working instead of explicitly mention "patch"

[enyst]

Maybe we can rephrase it as "MUST solve the task".

[xingyaoww]

@enyst I think it ultimately comes down to the eventual effectiveness -- "MUST solve the task" might not work very well of o1 :( - I guess we can wait for @AlexCuadron's testing in terms of what works and what doesn't, and we can figure out from there

[AlexCuadron]

@xiangyue9607 @enyst O1 is not very good at instruction following, it needs a reminder at the end. Otherwise, it thinks that after finishing reproducing the issue its task is done and it generates a <finish></finish>
But I can try to add a reminder to produce meaningful changes to the codebase before submission.