-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event search endpoint with pagination and filtering #4688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factor-session-event-handling
- Split _initialize_agent into smaller focused methods: - _set_loading_state - _extract_config_args - _configure_llm - _start_agent_session - Split on_event into smaller focused methods: - _should_skip_event - _is_environment_feedback_event - _send_as_agent_event Each method now has a single responsibility and clear documentation.
- Move get_matching_events to EventStream class - Extract filtering logic to _should_filter_event method - Change pagination to use stream indices - Add proper limit validation - Remove unnecessary total events count - Improve error handling and documentation
- Add tests for event type filtering - Add tests for text search functionality - Add tests for source filtering - Add tests for pagination - Add tests for limit validation - Fix source filtering to use enum value instead of name
…nds-AI/OpenHands into feature/add-event-search-endpoint
tobitege
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Endpoint to get the content of the EventStream via REST
(I think the line above should be included in release notes)
I needed this for debugging. e.g.:
Auto Generated by OpenHands
This PR adds a new
/api/events/search
endpoint that allows searching through the event stream with pagination and filtering capabilities.Features:
Example usage:
To run this PR locally, use the following command: