fix(frontend): Error when API key is not entered is not clear

[Yashwanth-Chandrakumar]

Give a summary of what the PR does, explaining any non-trivial design decisions

Added a modal for prompting the user to input an API Key in settings during startup and in session.

Link of any specific issues this addresses

Resolves #4236

[Yashwanth-Chandrakumar]

@amanape is this good

[Yashwanth-Chandrakumar]

@amanape i have solved the issue but why isnt it merged

[amanape]

I will give a proper review soon, sorry for the delay! In the meantime, I see that there are some linting issues on the frontend. Could you take care of it to pass the GitHub CI?

[Yashwanth-Chandrakumar]

Yes i think the prettier in my code editor is causing the problem will solve it. @amanape

[Yashwanth-Chandrakumar]

@amanape solved the lint issues perfect to merge

[amanape]

The functionality does not work when pressing "Save". The flow should look something like this:

• User presses "Save"
• If there is no API key, show modal
• Otherwise, send the save settings action request (it currently only does this)

We are using Remix to handle form actions. Instead of keeping LLM_API_KEY changes in the hasEnteredKey state, we can access this setting from the formRef:

const formData = new FormData(formRef.current); // assuming formRef.current is not undefined
const apiKey = formData.get("api-key");

You should prefer using Remix / React Router (latest version) API to handle form data and navigation states. I recommend reading their documentation for more information!

[Yashwanth-Chandrakumar]

@amanape ok i will implement the changes and come back

[Yashwanth-Chandrakumar]

Hi @amanape corrected the flow and other eslint issues (removed all the console log statements).

[Yashwanth-Chandrakumar]

@amanape all checks are done can we merge it

[amanape]

There seems to be just one bug:

1. Set API key and save
2. Open settings again
3. Clear API key input and press "Save"
4. Confirm warning modal

In this case, the API key is not actually removed, and still there.

[Yashwanth-Chandrakumar]

@amanape solved the bug, ready to merge

[amanape]

Thanks for the changes! Bonus points for handling the zIndex, too.