-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime): use micromamba instead of mamba and fix build issue #4154
Conversation
in the docker script:
I think the
|
You are probably right! Though the weird thing is i can build the exact dockerfile locally, as well as on the remote runtime 😓. I confirmed that this PR allow the previously fail image to successfully build and run |
Just to note for the record: when we have switched from (it's similar to |
Set CONDA_FORGE_YES to yes seems to also include Anaconda's commercial source when I'm testing the RemoteRuntime:
Try set it back to no to see if it work (i think |
That's strange! I think the install script does this?
|
This reverts commit cdabea0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awaiting the tests go through.
Thanks for the hard work! 🙏
End-user friendly description of the problem this fixes or functionality that this introduces
Improve the docker runtime build speed & fix bugs in build
Give a summary of what the PR does, explaining any non-trivial design decisions
This means
micromamba
is faster to install than miniforge/mamba, which will help in evaluation scenario where you may need to build thousands of containers..This PR:
miniforge3
tomicromamba
openhands
environment, instead of the base environment - because No other packages should be installed to base and we've been using this wrong for a while - I believe this is the cause of [Bug]: Runtime failed to build due to Mamba Error #4153Link of any specific issues this addresses
May fix #4153
Should also fix #4164
Some explanation of how this can fix #4153 #4164
slack message link
FROM oh_v0.9.7_XXX
and you try to install playwrightThe root issue is that we install useful stuff (playwright) in the base environment (where core mamba/conda reside), which is discouraged: https://mamba.readthedocs.io/en/latest/user_guide/troubleshooting.html#no-other-packages-should-be-installed-to-base