Fix save settings bug

All-Hands-AI · Dec 30, 2024 · ecde867 · ecde867
1 parent 9dfc732
commit ecde867
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/frontend/src/components/features/sidebar/sidebar.tsx b/frontend/src/components/features/sidebar/sidebar.tsx
@@ -21,8 +21,6 @@ export function Sidebar() {
   const { logout } = useAuth();
   const { isUpToDate: settingsAreUpToDate } = useSettingsUpToDate();
 
-  console.warn({ settingsAreUpToDate });
-
   const [accountSettingsModalOpen, setAccountSettingsModalOpen] =
     React.useState(false);
   const [settingsModalIsOpen, setSettingsModalIsOpen] = React.useState(false);

diff --git a/openhands/server/routes/settings.py b/openhands/server/routes/settings.py
@@ -46,7 +46,10 @@ async def store_settings(
         settings_store = await SettingsStoreImpl.get_instance(config, github_token)
         existing_settings = await settings_store.load()
         if existing_settings:
-            settings = Settings(**{**existing_settings.__dict__, **settings.__dict__})
+            # Only update settings that are not None with the new values
+            for key, value in settings.__dict__.items():
+                if value is None:
+                    setattr(settings, key, getattr(existing_settings, key))
             if settings.llm_api_key is None:
                 settings.llm_api_key = existing_settings.llm_api_key
         await settings_store.store(settings)