Skip to content

Commit

Permalink
Consolidate duplicate translation keys: LETS_START_BUILDING -> LANDIN…
Browse files Browse the repository at this point in the history
…G$TITLE
  • Loading branch information
openhands-agent committed Jan 6, 2025
1 parent 4b80de4 commit 998e16a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 22 deletions.
6 changes: 3 additions & 3 deletions frontend/__tests__/components/landing-translations.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe("Landing page translations", () => {
return (
<div>
<div data-testid="main-content">
<h1>{t("LETS_START_BUILDING")}</h1>
<h1>{t("LANDING$TITLE")}</h1>
<button>{t("OPEN_IN_VSCODE")}</button>
<button>{t("INCREASE_TEST_COVERAGE")}</button>
<button>{t("AUTO_MERGE_PRS")}</button>
Expand Down Expand Up @@ -89,7 +89,7 @@ describe("Landing page translations", () => {
render(<TestComponent />);

// Check main content translations
expect(screen.getByText("開発を始めましょう!")).toBeInTheDocument();
expect(screen.getByText("一緒に開発を始めましょう!")).toBeInTheDocument();
expect(screen.getByText("VS Codeで開く")).toBeInTheDocument();
expect(screen.getByText("テストカバレッジを向上")).toBeInTheDocument();
expect(screen.getByText("PRを自動マージ")).toBeInTheDocument();
Expand Down Expand Up @@ -123,7 +123,7 @@ describe("Landing page translations", () => {
test("all translation keys should have translations for all supported languages", () => {
// Test all translation keys used in the component
const translationKeys = [
"LETS_START_BUILDING",
"LANDING$TITLE",
"OPEN_IN_VSCODE",
"INCREASE_TEST_COVERAGE",
"AUTO_MERGE_PRS",
Expand Down
2 changes: 1 addition & 1 deletion frontend/__tests__/utils/i18n-test-utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const mockI18n = {
"SUGGESTIONS$TODO_APP": "ToDoリストアプリを開発する",
"LANDING$BUILD_APP_BUTTON": "プルリクエストを表示するアプリを開発する",
"SUGGESTIONS$HACKER_NEWS": "Hacker Newsのトップ記事を表示するbashスクリプトを作成する",
"LETS_START_BUILDING": "開発を始めましょう!",
"LANDING$TITLE": "一緒に開発を始めましょう!",
"OPEN_IN_VSCODE": "VS Codeで開く",
"INCREASE_TEST_COVERAGE": "テストカバレッジを向上",
"AUTO_MERGE_PRS": "PRを自動マージ",
Expand Down
2 changes: 1 addition & 1 deletion frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-react": "^7.37.3",
"eslint-plugin-react-hooks": "^4.6.2",
"husky": "^9.1.6",
"husky": "^9.1.7",
"jsdom": "^25.0.1",
"lint-staged": "^15.3.0",
"msw": "^2.6.6",
Expand Down
19 changes: 3 additions & 16 deletions frontend/src/i18n/translation.json
Original file line number Diff line number Diff line change
@@ -1,19 +1,5 @@
{
"LETS_START_BUILDING": {
"en": "Let's start building!",
"ja": "開発を始めましょう!",
"zh-CN": "让我们开始构建!",
"zh-TW": "讓我們開始構建!",
"ko-KR": "구축을 시작해봅시다!",
"de": "Lass uns anfangen zu bauen!",
"no": "La oss begynne å bygge!",
"it": "Iniziamo a costruire!",
"pt": "Vamos começar a construir!",
"es": "¡Empecemos a construir!",
"ar": "دعنا نبدأ البناء!",
"fr": "Commençons à construire !",
"tr": "Hadi inşa etmeye başlayalım!"
},

"WORKSPACE$TITLE": {
"en": "OpenHands Workspace",
"zh-CN": "OpenHands 工作区",
Expand Down Expand Up @@ -1652,7 +1638,8 @@
"it": "Iniziamo a costruire!",
"pt": "Vamos começar a construir!",
"ar": "هيا نبدأ البناء!",
"no": "La oss begynne å bygge!"
"no": "La oss begynne å bygge!",
"tr": "Hadi inşa etmeye başlayalım!"
},
"LANDING$SUBTITLE": {
"en": "OpenHands makes it easy to build and maintain software using a simple prompt.",
Expand Down

0 comments on commit 998e16a

Please sign in to comment.