Skip to content

Commit

Permalink
Fix micro_agents tests
Browse files Browse the repository at this point in the history
  • Loading branch information
openhands-agent committed Feb 23, 2025
1 parent 5268487 commit 82e2416
Showing 1 changed file with 12 additions and 28 deletions.
40 changes: 12 additions & 28 deletions tests/unit/test_micro_agents.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from openhands.controller.agent import Agent
from openhands.controller.state.state import State
from openhands.core.config import AgentConfig
from openhands.core.message import Message, TextContent
from openhands.events.action import MessageAction
from openhands.events.stream import EventStream
from openhands.storage import get_file_store
Expand Down Expand Up @@ -57,12 +58,7 @@ def test_coder_agent_with_summary(event_stream: EventStream, agent_configs: dict
mock_llm = MagicMock()
content = json.dumps({'action': 'finish', 'args': {}})
mock_llm.completion.return_value = {'choices': [{'message': {'content': content}}]}
mock_llm.format_messages_for_llm.return_value = [
{
'role': 'user',
'content': "This is a dummy task. This is a dummy summary about this repo. Here's a summary of the codebase, as it relates to this task.",
}
]
mock_llm.format_messages_for_llm = lambda messages: messages

coder_agent = Agent.get_cls('CoderAgent')(
llm=mock_llm, config=agent_configs['CoderAgent']
Expand All @@ -80,11 +76,10 @@ def test_coder_agent_with_summary(event_stream: EventStream, agent_configs: dict

mock_llm.completion.assert_called_once()
_, kwargs = mock_llm.completion.call_args
prompt_element = kwargs['messages'][0]['content']
if isinstance(prompt_element, dict):
prompt = prompt_element['content']
else:
prompt = prompt_element
message = kwargs['messages']
assert isinstance(message, Message)
assert len(message.content) == 1
prompt = message.content[0].text
assert task in prompt
assert "Here's a summary of the codebase, as it relates to this task" in prompt
assert summary in prompt
Expand All @@ -97,17 +92,7 @@ def test_coder_agent_without_summary(event_stream: EventStream, agent_configs: d
mock_llm = MagicMock()
content = json.dumps({'action': 'finish', 'args': {}})
mock_llm.completion.return_value = {'choices': [{'message': {'content': content}}]}
mock_llm.format_messages_for_llm.return_value = [
{
'role': 'user',
'content': [
{
'type': 'text',
'text': "This is a dummy task. This is a dummy summary about this repo. Here's a summary of the codebase, as it relates to this task.",
}
],
}
]
mock_llm.format_messages_for_llm = lambda messages: messages

coder_agent = Agent.get_cls('CoderAgent')(
llm=mock_llm, config=agent_configs['CoderAgent']
Expand All @@ -125,10 +110,9 @@ def test_coder_agent_without_summary(event_stream: EventStream, agent_configs: d

mock_llm.completion.assert_called_once()
_, kwargs = mock_llm.completion.call_args
prompt_element = kwargs['messages'][0]['content']
if isinstance(prompt_element, dict):
prompt = prompt_element['content']
else:
prompt = prompt_element
print(f'\n{prompt_element}\n')
message = kwargs['messages']
assert isinstance(message, Message)
assert len(message.content) == 1
prompt = message.content[0].text
print(f'\n{prompt}\n')
assert "Here's a summary of the codebase, as it relates to this task" not in prompt

0 comments on commit 82e2416

Please sign in to comment.