Skip to content

Commit

Permalink
Fix: [Bug] Do not render editor action buttons (save/discard) when di…
Browse files Browse the repository at this point in the history
…splaying non-code files (#4903)
  • Loading branch information
malhotra5 authored Nov 14, 2024
1 parent 8dee334 commit 38dc41c
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion frontend/src/routes/_oh.app._index/route.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,18 @@ import CodeEditorCompoonent from "./code-editor-component";
import { useFiles } from "#/context/files";
import { EditorActions } from "#/components/editor-actions";

const ASSET_FILE_TYPES = [
".png",
".jpg",
".jpeg",
".bmp",
".gif",
".pdf",
".mp4",
".webm",
".ogg",
];

export const clientLoader = async () => {
const token = localStorage.getItem("token");
return json({ token });
Expand Down Expand Up @@ -104,6 +116,10 @@ function CodeEditor() {
if (selectedPath) discardChanges(selectedPath);
};

const isAssetFileType = selectedPath
? ASSET_FILE_TYPES.some((ext) => selectedPath.endsWith(ext))
: false;

return (
<div className="flex h-full bg-neutral-900 relative">
<FileExplorer
Expand All @@ -112,7 +128,7 @@ function CodeEditor() {
error={errors.getFiles}
/>
<div className="w-full">
{selectedPath && (
{selectedPath && !isAssetFileType && (
<div className="flex w-full items-center justify-between self-end p-2">
<span className="text-sm text-neutral-500">{selectedPath}</span>
<EditorActions
Expand Down

0 comments on commit 38dc41c

Please sign in to comment.