fix(runtime): stale cachedData sometimes gets accepted due to some …

…bugs in V8, so we need to introduce our own check based on timestamps
AlinaNova21 · Sep 12, 2017 · 6b3a5c1 · 6b3a5c1
1 parent db4f3ab
commit 6b3a5c1
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/lib/runtime.js b/lib/runtime.js
@@ -123,7 +123,14 @@ process.on('message', (message) => {
         let runtimeData = data[0];
         let scriptCachedData = {};
         var activeSegments, publicSegments, defaultPublicSegment, activeForeignSegment;
-        scriptCachedData.cachedData = _.mapValues(data[1], i => Buffer.from(i, 'base64'));
+        if(data[1] && data[1]['.timestamp'] == runtimeData.userCodeTimestamp) {
+            scriptCachedData.cachedData = {};
+            for(let i in data[1]) {
+                if(i != '.timestamp') {
+                    scriptCachedData.cachedData[i] = Buffer.from(data[1][i], 'base64');
+                }
+            }
+        }
 
         runtimeData.staticTerrainData = staticTerrainData;
 
@@ -364,7 +371,8 @@ process.on('message', (message) => {
         if(scriptCachedData.cachedDataProduced) {
             env.hmset(
                 env.keys.SCRIPT_CACHED_DATA + message.userId,
-                _.mapValues(scriptCachedData.cachedDataProduced, i => i.toString('base64')))
+                Object.assign({'.timestamp': runtimeData.userCodeTimestamp},
+                    _.mapValues(scriptCachedData.cachedDataProduced, i => i.toString('base64'))))
             .then(() => env.expire(env.keys.SCRIPT_CACHED_DATA + message.userId, 3*3600));
 
         }