[ZDC] Qc additions #2510
Open
[ZDC] Qc additions #2510
+439
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e central event function
stefan-zugravel
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
Barthelemy
requested changes
Feb 20, 2025
| namespace o2::quality_control_modules::zdc | ||
| { | ||
|
|
||
| /// \brief Example QC Check |
There was a problem hiding this comment.
You forgot to update the class description
| if (mo->getName() == mVectHistoCheck.at(ih).nameHisto) { | ||
| // std::ofstream debugFile; |
There was a problem hiding this comment.
Coding guidelines encourage the removal of commented out code.
| if (!std::equal(std::begin(ratio_array), std::end(ratio_array), std::begin(COMPARATOR_ARRAY))) { | ||
| mVectHistoCheck.at(ih).numE += 1; | ||
| mVectHistoCheck.at(ih).stringE = mVectHistoCheck.at(ih).stringE + mVectHistoCheck.at(ih).paramch.at(x).ch + " "; | ||
| // std::ofstream debugFile; |
| mVectHistoCheck.at(ih).quality = 3; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| // dumpStruct(); |
| } else { | ||
| msgr->SetTextColor(kRed); | ||
| } | ||
| h->GetListOfFunctions()->Add(msgr); |
There was a problem hiding this comment.
you are potentially adding a msg for every bin in the plot. That is potentially very dangerous. A plot with a large number of "functions" becomes impossible to display and usually crashes the QCG, respectively the ROOT browser. How many bins are there ?
Please consider another way if indicating problems.
There was a problem hiding this comment.
The plot would look like this. There are 12x26 bins
| @@ -600,6 +621,12 @@ bool ZDCRecDataTask::add2DHisto(std::string typeH, std::string name, std::string | |||
| h2d.ch1 = ch1; | |||
| h2d.typech2 = typeCh2; | |||
| h2d.ch2 = ch2; | |||
| // Begin Stefan addition | |||
| if (typeH == "CENTR_ZNA") { | |||
| // h2d.histo->GetXaxis()->SetTitle("test2"); | |||
There was a problem hiding this comment.
this code does nothing.
| } else { | ||
| SetConfigCentralEvent(0.0, 0); | ||
| } | ||
| // End Stefan addition |
There was a problem hiding this comment.
do not add such comments. Git keeps track of this for you.
| @@ -850,7 +886,7 @@ int ZDCRecDataTask::process(const gsl::span<const o2::zdc::BCRecData>& RecBC, | |||
| mEv.centroidZNC(x, y); | |||
| mHisto2D.at(i).histo->Fill(x, y); | |||
| } else { | |||
| if (((float)mEv.tdcV(5, 0) > -2.5 && (float)mEv.tdcV(5, 0) < 2.5) && ((float)mEv.tdcV(4, 0) > -2.5 && (float)mEv.tdcV(4, 0) < 2.5)) { | |||
| if (IsEventCentral()) { // STEFAN | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> Addition of BC alignment Plot (with json configurable check)
-> Addition of configurable cut window for centroid (Central_envent_config)
-> Beautyfied centroids