Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWGCF: flow: add Run3ITSall7Layers option and a new run-by-run task #8201

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

Luzhiyongg
Copy link
Contributor

@Luzhiyongg Luzhiyongg commented Oct 29, 2024

Hi reviewers,
The FlowTask.cxx I am using has already consume a lot of memory (>500 MB per wagon). So I'd like to create to new task to hold the run-by-run output. This task would be lightweight for each run.

// Add output histograms to the registry
std::vector<int> temp = cfgRunNumbers;
RunNumbers = temp;
for (auto& runNumber : RunNumbers) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried

    for (auto runNumber : cfgRunNumbers.value)

Comment on lines +109 to +110
std::vector<int> temp = cfgRunNumbers;
RunNumbers = temp;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried

std::vector<int> RunNumbers = cfgRunNumbers.value;

Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to have a look at my comments for the next iteration

@victor-gonzalez victor-gonzalez enabled auto-merge (squash) October 29, 2024 15:24
@victor-gonzalez victor-gonzalez merged commit 1bc5ff9 into AliceO2Group:master Oct 30, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants