-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWGHF: Add finding leading particle in correlatorLcHadrons #8183
base: master
Are you sure you want to change the base?
Conversation
PWGHF/HFC/Utils/utilsCorrelations.h
Outdated
/// \brief Utilities for HFC analyses | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add yourself as author.
/// \brief Utilities for HFC analyses | |
/// \brief Utilities for HFC analyses | |
/// \author ... | |
PWGHF/HFC/Utils/utilsCorrelations.h
Outdated
#include <TString.h> | ||
#include <cmath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include <TString.h> | |
#include <cmath> | |
#include <cmath> |
Why do you need TString
?
Include the header which defines o2::constants::math::PI
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to include TPDGCode.h
for the named PDG codes.
Co-authored-by: Vít Kučera <[email protected]>
PWGHF/HFC/Utils/utilsCorrelations.h
Outdated
{ | ||
auto leadingParticle = tracks.begin(); | ||
for (auto const& track : tracks) { | ||
if (std::abs(track.dcaXY()) >= 1. || std::abs(track.dcaZ()) >= 1.) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be configurable.
PWGHF/HFC/Utils/utilsCorrelations.h
Outdated
/// \file utilsCorrelations.h | ||
/// \brief Xu Wang <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix
#ifndef PWGHF_HFC_UTILS_UTILSCORRELATIONS_H_ | ||
#define PWGHF_HFC_UTILS_UTILSCORRELATIONS_H_ | ||
|
||
#include <cmath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but I don't quite understand what you mean by "fix."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have not addressed my previous comments correctly. See #8183 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I overlooked this message.
Co-authored-by: Vít Kučera <[email protected]>
Co-authored-by: Vít Kučera <[email protected]>
Co-authored-by: Vít Kučera <[email protected]>
Dear, experts
Sorry for bothering you again.
I would like to add a function to find the leading particle in correlatorLcHadrons. This is similar to what we have in correlatorD0Hadrons, which you can see through this link.
#4962
#7722