PWGHF: Add finding leading particle in correlatorLcHadrons #8183
+294
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1481014945
requested review from
alibuild,
vkucera,
fcolamar,
fgrosa,
fcatalan92,
mfaggin,
mmazzilli,
deepathoms,
NicoleBastid,
hahassan7,
jpxrk and
apalasciano
as code owners
vkucera
requested changes
Oct 29, 2024
PWGHF/HFC/Utils/utilsCorrelations.h
Outdated
Comment on lines
13
to
14
| /// \brief Utilities for HFC analyses | ||
|
|
There was a problem hiding this comment.
Add yourself as author.
Suggested change
| /// \brief Utilities for HFC analyses | |
| /// \brief Utilities for HFC analyses | |
| /// \author ... | |
PWGHF/HFC/Utils/utilsCorrelations.h
Outdated
Comment on lines
18
to
19
| #include <TString.h> | ||
| #include <cmath> |
There was a problem hiding this comment.
Suggested change
| #include <TString.h> | |
| #include <cmath> | |
| #include <cmath> |
Why do you need TString?
Include the header which defines o2::constants::math::PI.
There was a problem hiding this comment.
You also need to include TPDGCode.h for the named PDG codes.
Co-authored-by: Vít Kučera <[email protected]>
vkucera
reviewed
Oct 29, 2024
vkucera
reviewed
Oct 29, 2024
vkucera
reviewed
Oct 29, 2024
vkucera
reviewed
Oct 29, 2024
PWGHF/HFC/Utils/utilsCorrelations.h
Outdated
| { | ||
| auto leadingParticle = tracks.begin(); | ||
| for (auto const& track : tracks) { | ||
| if (std::abs(track.dcaXY()) >= 1. || std::abs(track.dcaZ()) >= 1.) { |
There was a problem hiding this comment.
These should be configurable.
vkucera
reviewed
Oct 29, 2024
PWGHF/HFC/Utils/utilsCorrelations.h
Outdated
vkucera
reviewed
Oct 29, 2024
| #ifndef PWGHF_HFC_UTILS_UTILSCORRELATIONS_H_ | ||
| #define PWGHF_HFC_UTILS_UTILSCORRELATIONS_H_ | ||
|
|
||
| #include <cmath> |
There was a problem hiding this comment.
I'm sorry, but I don't quite understand what you mean by "fix."
There was a problem hiding this comment.
You have not addressed my previous comments correctly. See #8183 (comment)
There was a problem hiding this comment.
Sorry, I overlooked this message.
vkucera
requested changes
Oct 29, 2024
Co-authored-by: Vít Kučera <[email protected]>
Co-authored-by: Vít Kučera <[email protected]>
Co-authored-by: Vít Kučera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear, experts
Sorry for bothering you again.
I would like to add a function to find the leading particle in correlatorLcHadrons. This is similar to what we have in correlatorD0Hadrons, which you can see through this link.
#4962
#7722