Remove model move to support low mem usage in SPMD-FSDP #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of SPMD-FSDP, the model movement is managed by the following code segment regardless of whether low memory usage mode is activated.
https://github.com/AlibabaPAI/xla/blob/63e20fb8e02243a27fc2486670a85d7b4ab03c1b/torch_xla/experimental/spmd_fully_sharded_data_parallel.py#L100
However, model movement may cause the
materialize_module
to fail under low memory usage.