-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter by multiple searchable columns #146
base: master
Are you sure you want to change the base?
Conversation
@AliHichem it looks like connection issue. can you please re-run build. |
@AliHichem any chance to merge this pull? |
Add filter by multiple searchable columns
@zgoniaiko the idea of search is to have targeted search that's why the global search is disabled, if we show the global search aside to the target search that will bring confusions and the end user (non-developer user) won't know which search input to use. I like to idea to bring the global search back BUT only in a way where we can toggle it with the input search something like :
|
@AliHichem we can configure global search now (disabled by default). |
@zgoniaiko by global search I mean a single input that will make a search on all the fields, the targeted search is the current per field search feature. In your work they work at the "same" time which is double search that is likely to be non-sense, plus the global input search is displayed at the same time with the per-field search which is still non-sense to me. If we want to add a global search input it has to be switchable with the per-field search and manageable by a config variable (in the search method configurator ) like explained in my last reply. |
@AliHichem issue with search input should be fixed in 8291c27 |
@AliHichem any chance to merge this PR? |
Conflicts: Tests/Ali/DatatableBundle/Util/DatatableTest.php
Conflicts: composer.json
Add filter by multiple searchable columns