Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sliding function,responsiveness,linked the whole box #516

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

sliding function,responsiveness,linked the whole box #516

wants to merge 5 commits into from

Conversation

saswatsam786
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed.
Fixes #402 (issue)

List any dependencies that are required for this change

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [Y ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

UI /UX changes

Attach gif or screenshot for changes.

  • Before :
    - After :

Checklist:

  • My code follows the style guidelines of this project
  • [Y ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ Y] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@saswatsam786
Copy link
Contributor Author

@harikesh409 @ravikr126 sir please check these commits.

@ravikr126 ravikr126 requested a review from harikesh409 May 27, 2021 05:03
@saswatsam786
Copy link
Contributor Author

@harikesh409 sir could you review it?

harikesh409
harikesh409 requested changes May 28, 2021
View reviewed changes
Copy link
Collaborator

@harikesh409 harikesh409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
The social sidebar position has been shifted mostly this is due to including bootstrap5 look into it.

index.html
@@ -9,6 +9,9 @@

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css"
integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous">
<link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-+0n0xVW2eSR5OomGNYDnhzAbDsOXxcvSN1TPprVMTNDbiYZCxYbOOl7+AMvyTG2x" crossorigin="anonymous">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already bootstrap 4 is present don't add another bootstrap version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sliding function will not work if i remove bootstrap 5 version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also bootstrap 4 sliding function is not so smooth compared to bootstrap 5

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but using 2 bootstrap versions is never recommended.

index.html Outdated Show resolved Hide resolved
css/style.css
height: 375px;
}

.text-center{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change the font-weight to a bootstrap class instead use .font-weight-bold to the tag where you need bold.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still this exists

@saswatsam786
Copy link
Contributor Author

@harikesh409 sir now can you give a check

@saswatsam786
Copy link
Contributor Author

image
The social sidebar position has been shifted mostly this is due to including bootstrap5 look into it.

sir I have fixed that issue

@saswatsam786
Copy link
Contributor Author

@harikesh409 sir could give a look now

harikesh409
harikesh409 requested changes May 29, 2021
View reviewed changes
Copy link
Collaborator

@harikesh409 harikesh409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just compare the home page of your code and the hosted home page you can see the UI difference in the navbar and footer this is due to bootstrap 5 inclusion you need to find a workaround without using bootstrap 5.

css/style.css
height: 375px;
}

.text-center{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still this exists

@saswatsam786
Copy link
Contributor Author

@harikesh409 @ravikr126 sir please give a check now

@saswatsam786 saswatsam786 requested a review from harikesh409 May 30, 2021 05:35
@harikesh409
Copy link
Collaborator

@harikesh409 @ravikr126 sir please give a check now

there are no changes, check before requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harikesh409 harikesh409 Awaiting requested review from harikesh409

Assignees

@saswatsam786 saswatsam786

Labels
changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Making "sharp your skill" section in homepage more interactive .
2 participants
@saswatsam786 @harikesh409