Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-25816 Allow to set a custom storage prefix for Authentication #10225

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

alep85
Copy link
Contributor

@alep85 alep85 commented Sep 16, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@alep85 alep85 changed the title AAE-25816 Provide a separate storage instance for the AuthModule AAE-25816 Allow to set a custom storage prefic for Authentication Sep 17, 2024
@alep85 alep85 changed the title AAE-25816 Allow to set a custom storage prefic for Authentication AAE-25816 Allow to set a custom storage prefix for Authentication Sep 17, 2024
@DenysVuika
Copy link
Contributor

@alep85 please see the StoragePrefixFactory introduced by @BSekula

@alep85 alep85 force-pushed the fix/AAE-25816-fe-token-refresh-error-when-custom-ui-and-default-ui-are-opened branch from c2e3541 to e5528cf Compare September 17, 2024 15:09
});

it('should be created', () => {
expect(service).toBeTruthy();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

…llow setting a custom storage prefix for authentication data stored in local storage
@alep85 alep85 force-pushed the fix/AAE-25816-fe-token-refresh-error-when-custom-ui-and-default-ui-are-opened branch from e5528cf to c3f5006 Compare September 17, 2024 15:24
Copy link

sonarcloud bot commented Sep 17, 2024

@alep85 alep85 marked this pull request as draft September 19, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants