[ACS-8749] View More tags button no longer shows when all tags are removed from a node #10221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapnil-verma-gl
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
dominikiwanekhyland
approved these changes
Sep 16, 2024
VitoAlbano
force-pushed
the
ng16-migration
branch
from
2b341c2
to
e9f47e8
Compare
VitoAlbano
force-pushed
the
ng16-migration
branch
from
ce5eef3
to
dace3aa
Compare
swapnil-verma-gl
force-pushed
the
dev-acs-8749-view-more-button
branch
from
85f2897
to
d3157f9
Compare
|
g-jaskowski
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Is an empty file intended?
There was a problem hiding this comment.
No, the changes intended in this PR are only in the dynamic-chip-list.component.html and dynamic-chip-list.component.spec.ts files. The other files have started showing up, due to rebase of the ng16-migration branch again. This was the same issue that caused the original PR (#10200) to have to be closed. I'll need to investigate this and update the PR accordingly
VitoAlbano
force-pushed
the
ng16-migration
branch
5 times, most recently
from
af1c58d
to
c83ee94
Compare
VitoAlbano
force-pushed
the
ng16-migration
branch
3 times, most recently
from
a803b2c
to
f789dec
Compare
|
Closing due to incorrect rebase issue again. Created #10285 with cherry picked commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
View more button was not getting hidden when all tags on a node were removed.
What is the new behaviour?
View more button now gets hidden
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/ACS-8749
Also, take a loot at #10200. This PR is a duplicate of that, and was created due to unsuccessful rebase to the latest ng16-migration branch