[ACS-8749] View More tags button no longer shows when all tags are removed from a node #10200
Conversation
swapnil-verma-gl
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
| @@ -26,7 +26,7 @@ | |||
| <button | |||
| data-automation-id="adf-dynamic-chip-list-view-more-button" | |||
| mat-button | |||
| [hidden]="!limitChipsDisplayed" | |||
| [hidden]="chipsToDisplay.length === 0 || !limitChipsDisplayed" | |||
There was a problem hiding this comment.
Maybe we could go with < 2? Since it still doesn't make too much sense to show it when there is only one tag
There was a problem hiding this comment.
The chipsToDisplay property only contains the chips that are to be currently displayed, not all chips that are present. By default, it will always have a length of at least 1, so that at least a single chip is shown. So having a check against < 2 will cause problems as it will hide the button in case the container is so small that only a single chip can be shown. See below video -
chips-to-display.mp4
VitoAlbano
force-pushed
the
ng16-migration
branch
from
62e81b3
to
db56f03
Compare
swapnil-verma-gl
force-pushed
the
dev-acs-8749-hide-view-more-button
branch
from
edb5524
to
6604ac3
Compare
|
|
Closing this PR in favour of #10221. This PR has got some rebase issue, and is showing more files than what were originally changed. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
View more button was not getting hidden when all tags were removed from a node
What is the new behaviour?
View more button now gets hidden
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/ACS-8749