Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add pprof endpoint #1365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jrcichra
Copy link

This will help debug running go2rtc instances.

Since the default http handler is used for the api, it is automatically registered.

@AlexxIT AlexxIT added the doubt label Sep 20, 2024
@AlexxIT
Copy link
Owner

AlexxIT commented Sep 20, 2024

I don't think it's good idea of using this without additional setting.

@jrcichra
Copy link
Author

Okay I can look into putting it behind a setting.

@jrcichra jrcichra force-pushed the pprof branch 2 times, most recently from 186fd14 to bb0c0bd Compare September 24, 2024 04:17
This will help debug running go2rtc instances.

By default the pprof endpoint is off.
It can be enabled via the api.pprof setting.
@jrcichra
Copy link
Author

I had to replace the default mux so pprof wouldn't auto register. When you specify the pprof flag it registers on the api mux.

@jrcichra
Copy link
Author

Hey @AlexxIT does this change look ok?

@AlexxIT
Copy link
Owner

AlexxIT commented Oct 18, 2024

I needs to think about this. I have design concept for access rights settings. But it will take time to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants